Feature/fas 531 us ajustements pour la gestion des lots mono types suite aux#398
Merged
lordinatrice merged 5 commits intoMay 28, 2026
Conversation
lordinatrice
force-pushed
the
feature/fas-531-us-ajustements-pour-la-gestion-des-lots-mono-types-suite-aux
branch
from
ae71112 to
540eb72
Compare
Un3x
approved these changes
May 27, 2026
Comment on lines
+18
to
+21
| if @public_market.lots.any? | ||
| steps << LOT_CONFIG_STEP | ||
| steps << FORM_CONFIG_STEP | ||
| end |
Collaborator
There was a problem hiding this comment.
Je me demande si on ne peut pas faire un truc un peu plus smart. C'est pas du tgout un sujet related à cette PR mais j'ai quand même le sentiment qu'on empile des exceptions et qu'en fait il y a une norme qui se dessine que l'on devrait exploiter pour refacto le bouzin.
Collaborator
Author
There was a problem hiding this comment.
oui je suis tout à fait d'accord. J'ai un ticket de refacto vis à vis des steps et du wizard que je vais caler sur le nouveau sprint avec les lots multi-types je pense que c'est le bon moment
lordinatrice
changed the base branch from
feature/fas-530-us-ajustements-pour-la-gestion-des-lots-mono-types
to
develop
lordinatrice
force-pushed
the
feature/fas-531-us-ajustements-pour-la-gestion-des-lots-mono-types-suite-aux
branch
from
540eb72 to
6befa1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.